Skip to content

Added logging for certificate verification when linked and added testing#178

Open
janssensjelle wants to merge 2 commits intohackthebox:mainfrom
janssensjelle:feature/log-certificate-verification
Open

Added logging for certificate verification when linked and added testing#178
janssensjelle wants to merge 2 commits intohackthebox:mainfrom
janssensjelle:feature/log-certificate-verification

Conversation

@janssensjelle
Copy link
Contributor

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

Sends a message to the verification channel of saying which user used which cert id

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

Add any other context or screenshots here.

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.13%. Comparing base (0f08c66) to head (7874bdc).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/webhooks/handlers/academy.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   61.74%   62.13%   +0.39%     
==========================================
  Files          50       50              
  Lines        2941     2945       +4     
==========================================
+ Hits         1816     1830      +14     
+ Misses       1125     1115      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants